Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split filtering features and rename #5413

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

KevinVandy
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Mar 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 70bf907. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@KevinVandy KevinVandy merged commit 01129cb into main Mar 15, 2024
2 checks passed
@KevinVandy KevinVandy deleted the split-filtering-features branch March 15, 2024 19:37
@matthawk60
Copy link

matthawk60 commented Mar 25, 2024

There are a bunch of examples that use FiltersTableState as a type. This completely breaks that.
I'd be more than happy to help contribute If I could get some information on why the filters were split in the first place. I have just added them back to the global types for now.

import '@tanstack/react-table'
import { ColumnMeta, ColumnFiltersState } from '@tanstack/table-core'

declare module '@tanstack/table-core' {
    interface ColumnMeta<TData extends RowData, TValue> {
        className?: string;
        headerClassName?: string;
        bodyClassName?: string;
        mobileClassName?: string;
        size?: number | 'auto';
        title?: string;
    }
    interface FiltersTableState {
        columnFilters: ColumnFiltersState;
        globalFilter: any;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants